Introduce keyword argument reset for sum! etc.
#36332
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkf
commented
Jun 17, 2020
Comment on lines
+1009
to
+1015
| if haskey(kw, :init) # backward compatibility | ||
| _kw_reset(kw) && !isempty(A) && fill!(rval, first(A)) | ||
| fill!(rind, zero(eltype(keys(A)))) | ||
| elseif _kw_reset(kw) | ||
| !isempty(A) && fill!(rval, first(A)) | ||
| fill!(rind, zero(eltype(keys(A)))) | ||
| end |
There was a problem hiding this comment.
The behavior init=false was not consistent with other multi-dimensional reducers. So I suggest to fix it.
It was added in #6894 by @timholy but it looks like it was an internal function back then. So, probably the consistency with other reducers and the usability for end-users were not the biggest concern.
Also, I'm not sure if we should keep the backward compatibility branch. But it's rather cheap so why not?
tkf
commented
Jun 17, 2020
| _kw_reset(kw::Iterators.Pairs) = _kw_reset(kw.data) | ||
| _kw_reset(::NamedTuple{(), Tuple{}}) = true | ||
| _kw_reset(kw::NamedTuple{(:reset,), Tuple{Bool}}) = kw.reset | ||
| _kw_reset(kw::NamedTuple{(:init,), Tuple{Bool}}) = kw.init |
There was a problem hiding this comment.
Should we depwarn when init is passed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #36266 for the discussion. The name of the argument is still discussed in #36266 (
resetis a placeholder ATM).close #36266