Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve inference broadly throughout REPL #37081

Merged
merged 6 commits into from
Aug 26, 2020
Merged

Improve inference broadly throughout REPL #37081

merged 6 commits into from
Aug 26, 2020

Commits on Aug 26, 2020

  1. REPL: move Options to improve inference (part of #37081) 

    Moving this earlier in the load sequence allows one to annotate the
return type of some methods.
    @timholy
    timholy committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    a49f830 View commit details
    Browse the repository at this point in the history

  2. REPL: add interfaces for abstract types and change one field type (pa… 

    …rt of #37081)

Since MIState and others have containers with abstract typing, these interfaces
fix inference problems broadly.
    @timholy
    timholy committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    ed23186 View commit details
    Browse the repository at this point in the history

  3. IO: improve inferrability of write and unsafe_write (part of #37081)

    @timholy
    timholy committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    1a33e6b View commit details
    Browse the repository at this point in the history

  4. REPL: add argument typing and improve implementations (part of #37081) 

    Since entire modules are marked `@nospecialize`, we need
to declare argument types anywhere we want good inference.
This also improves numerous implementations to ensure
inferrability.

For the completion methods, notice this changes typeof(ret[2]) from
UnitRange{Int64} to UnitRange{Int}. Internally, the methods are using
Int rather than Int64, so consistently supporting Int64 would require
more extensive changes.
    @timholy
    timholy committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    73e9ccd View commit details
    Browse the repository at this point in the history

  5. REPL: add argtypes to keymap functions (part of #37081)

    @timholy
    timholy committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    2303b8f View commit details
    Browse the repository at this point in the history

  6. REPL: test inference in LineEdit (part of #37081)

    @timholy
    timholy committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    3ebadef View commit details
    Browse the repository at this point in the history