Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing support for addition and subtraction #37222

Merged
merged 6 commits into from
Aug 31, 2020
Merged

Add missing support for addition and subtraction #37222

merged 6 commits into from
Aug 31, 2020

Commits on Aug 26, 2020

  1. Add missing support for addition and subtraction 

    Inspired by the discussion in JuliaLang#28570
    @nilshg
    nilshg committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    5416a09 View commit details
    Browse the repository at this point in the history

  2. Update stdlib/Dates/src/arithmetic.jl 

    Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
    @nilshg @nalimilan
    nilshg and nalimilan committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    6e44f90 View commit details
    Browse the repository at this point in the history

  3. Add tests for missing arithmetic 

    These test the exported subtypes of `AbstractTime`
    @nilshg
    nilshg committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    ffa2884 View commit details
    Browse the repository at this point in the history

  4. Remove trailing whitespace

    @nalimilan
    nalimilan committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    6e7aea4 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Hardcode DatePeriod and TimePeriod subtypes 

    Avoids the usage of `subtypes` function, which would need to be imported from `InteractiveUtils` otherwise
    @nilshg
    nilshg committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    4d39cf4 View commit details
    Browse the repository at this point in the history

  2. Update stdlib/Dates/test/arithmetic.jl 

    Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
    @nilshg @nalimilan
    nilshg and nalimilan committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    8631987 View commit details
    Browse the repository at this point in the history