Implement dynamic SNCA domtree algorithm #37884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
added
the
compiler:optimizer
|
@nanosoldier |
|
Wrong syntax: @nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt |
|
So fast... |
That server upgrade was worth it. |
This comment has been minimized.
This comment has been minimized.
|
@nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt |
vchuravy
force-pushed
the
vc/dynamic_snca
branch
from
03637df
to
4f5725e
Compare
…ons and deletions The DFS tree associated with a CFG now keeps track of postorder as well as preorder numbers. The DFS tree, as well as the state associated with the SNCA algorithm for finding (immediate) dominators is now stored in DomTree and reused for Dynamic SNCA.
… predecessors For now, just construct the domtree when we make an `IncrementalCompact` rather than try to update it (the domtree) incrementally.
…of CFG This is in anticipation of domtrees being added to CFGs.
This is so we can add type declarations to fields in ir.jl that are domtrees, by breaking the dependency loop between domtree.jl (uses basic blocks but defines domtrees) and ir.jl (uses domtrees but defined basic blocks).
vchuravy
force-pushed
the
vc/dynamic_snca
branch
from
4f5725e
to
f7852e3
Compare
|
@nanosoldier |
|
Your package evaluation job has completed - no new issues were detected. A full report can be found here. cc @maleadt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at rebasing #33730 in #37882. I decided that it would be better to split that PR into two pieces.
First the implementation of Dynamic SNCA by @yhls and some of the code shuffling. On it's own it shouldn't have
any negative performance impacts and it is a really nice piece of work that I don't want to lose to the sands of time.
I stripped out the second piece, which is the actual dynamic updating of the domtree during the optimizations.
That would be nice to have, if we want to do CFG manipulations like #36832, or turn on DCE generally.
Since that seems have a performance impact, holding back on it seems to make the most sense, until we
investigated options like batching operations.
@yhls if you time it would be great if you can look this over once, to see if I messed up the splitting.