Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix REPL precompile generation for Pkg #38387

Merged
merged 1 commit into from Nov 12, 2020
Merged

fix REPL precompile generation for Pkg #38387

merged 1 commit into from Nov 12, 2020

Conversation

KristofferC
Copy link
Sponsor Member

For some reason, the auto precompile thing in Pkg messes something up so that the REPL commands for Pkg are not executed when generate_precompile.jl is running. I am guessing the REPL commands get put in while the pretty output from Pkg.precompile is running and that somehow makes them not run. Turn it off for now.

Fixes JuliaLang/Pkg.jl#2200

@timholy
Copy link
Sponsor Member

timholy commented Nov 11, 2020

Probably unrelated, but I've noticed that the build order of some of the stdlibs is a bit whacked. We build Pkg before REPL despite the fact that Pkg depends on REPL. Perhaps the only "problem" is misleading information about how long each stdlib contributes to the build process (which is hardly worth worrying about), but I thought it might be worth mentioning in the context of potential order-dependence of precompilation.

@KristofferC
Copy link
Sponsor Member Author

Perhaps the only "problem" is misleading information about how long each stdlib contributes to the build process (which is hardly worth worrying about), but I thought it might be worth mentioning in the context of potential order-dependence of precompilation.

There was a time they were ordered, in fact the comment is still there (although now being completely false):

# Stdlibs manually sorted in top down order

@KristofferC KristofferC merged commit bd3d9ee into master Nov 12, 2020
@KristofferC KristofferC deleted the kc/pkg_prec branch November 12, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pkg REPL feels slower than on 1.5
3 participants