Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_pcre_version() and check_pcre() #3873

Closed
wants to merge 1 commit into from

Conversation

staticfloat
Copy link
Sponsor Member

To ensure that the pcre version is what we want.

I'm not sure if 8.31 is the actual minimum version number we support, it's just what I had on my machine.

…pcre version is what we want.

Print out the pcre version when verbosely verioninfo()'ing
Do everything with strings and floats to try to avoid actually using PCRE when checking the version number
@staticfloat
Copy link
Sponsor Member Author

For context/why this is needed: #3838 (comment)

@StefanKarpinski
Copy link
Sponsor Member

Seems reasonable to me.

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jul 29, 2013

julia$ export LD_LIBRARY_PATH=/opt/local/lib
....
julia> version_string = bytestring( ccall((:pcre_version, "libpcre"), Ptr{Uint8}, () ))
"8.33 2013-05-28"

julia> isabspath("/")
false

@staticfloat
Copy link
Sponsor Member Author

@vtjnash; I'm assuming that is meant to illustrate that although version 8.33 is being linked to, ismatch is still failing? There must be some configuration mismatch somewhere then. Brew's pcre configure line looks like this:

system "./configure", "--disable-dependency-tracking",
                          "--prefix=#{prefix}",
                          "--enable-utf8",
                          "--enable-unicode-properties",
                          "--enable-pcregrep-libz",
                          "--enable-pcregrep-libbz2",
                          "--enable-jit"

Macport's looks like this:

configure.args      --docdir=${prefix}/share/doc/${name}
                        --disable-silent-rules \
                        --enable-pcre16 \
                        --enable-pcre32 \
                        --enable-jit \
                        --enable-unicode-properties \
                        --enable-pcregrep-libz \
                        --enable-pcregrep-libbz2 \
                        --enable-pcretest-libedit

and Macports also contains this diff on the configure file which seems to take out some pthreads flags. Can you try changing the configure flags to those used by brew and seeing if the Macports pcre works then?

@JeffBezanson
Copy link
Sponsor Member

Can this go in the PCRE module?

@staticfloat
Copy link
Sponsor Member Author

I suppose that makes sense! However, we're hashing stuff out in #3838 to see if we can't make this detection more bulletproof. I'll reorganize once we have something that works.

Closing until then

@ViralBShah
Copy link
Member

We should certainly bump the PCRE version if that helps.

@staticfloat staticfloat deleted the sf/pcreversioncheck branch July 30, 2014 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants