Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Bump the Downloads stdlib from 02e77ae to 1a31dc8 #38808

Closed
wants to merge 1 commit into from
Closed

🤖 Bump the Downloads stdlib from 02e77ae to 1a31dc8 #38808

wants to merge 1 commit into from

Conversation

DilumAluthgeBot
Copy link
Contributor

Stdlib: Downloads
Branch: master
Old commit: 02e77ae
New commit: 1a31dc8

$ git log --oneline 02e77ae..1a31dc8
1a31dc8 Update Project.toml
f4cd66c bump compat for NetworkOptions: 1.2 now required
8671270 Update TagBot setup (#81)
924400a SSH NetworkOptions: configure known_hosts and host verification (#80)
4678547 set_ca_roots_path: fix bug when path is a directory (#79)

@StefanKarpinski StefanKarpinski self-assigned this Dec 10, 2020
@StefanKarpinski
Copy link
Sponsor Member

Actually, this won't pass until after #38809 is merged. Would be nice if all stdlib updates were done in a single PR.

@DilumAluthge
Copy link
Member

Actually, this won't pass until after #38809 is merged. Would be nice if all stdlib updates were done in a single PR.

It's a good idea. Can you open an issue on BumpStdlibs.jl so I don't forget?

@StefanKarpinski
Copy link
Sponsor Member

I don't understand how this passed CI ☹️

@DilumAluthge
Copy link
Member

I don't understand how this passed CI ☹️

That's concerning.

@DilumAluthge
Copy link
Member

Does Base Julia CI run the tests for the Downloads stdlib?

@StefanKarpinski
Copy link
Sponsor Member

Yeah, they're in there and they appear to have run. I vaguely remember that @KristofferC and/or @vtjnash might have turned of some tests at some point?

@StefanKarpinski
Copy link
Sponsor Member

They don't appear to be skipped from what I can tell: Downloads appears in the output and isn't filtered in choosetests or runtests in any way that I can see.

@StefanKarpinski
Copy link
Sponsor Member

False alarm: the version of NetworkOptions on master was much newer than I thought it was.

@StefanKarpinski
Copy link
Sponsor Member

I'm still going to rerun this in a new bump PR though.

@DilumAluthgeBot DilumAluthgeBot deleted the BumpStdlibs/Downloads-1a31dc8 branch December 10, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants