add a missing propagate_inbounds to a getindex method #40281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
changed the title
KristofferC
force-pushed
the
kc/revert_getindex_change
branch
from
e30af53
to
24ccd3c
Compare
KristofferC
changed the title
KristofferC
force-pushed
the
kc/revert_getindex_change
branch
from
24ccd3c
to
d5869b7
Compare
|
Does this fix #40276? |
|
Doesn't look like it. |
mbauman
approved these changes
Mar 31, 2021
KristofferC
added a commit
that referenced
this pull request
Apr 4, 2021
* add a missing propagate_inbounds (cherry picked from commit 80002db)
KristofferC
added a commit
that referenced
this pull request
Apr 4, 2021
* add a missing propagate_inbounds (cherry picked from commit 80002db)
KristofferC
added a commit
that referenced
this pull request
Apr 4, 2021
* add a missing propagate_inbounds (cherry picked from commit 80002db)
This was referenced Apr 4, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* add a missing propagate_inbounds
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
* add a missing propagate_inbounds
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
* add a missing propagate_inbounds
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
* add a missing propagate_inbounds (cherry picked from commit 80002db)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #36427, many changes were made to reduce the number of invalidations during Julia bootstrap. One of them was the addition of this method:
julia/base/abstractarray.jl
Lines 1172 to 1173 in c0f8aef
This method lacks a
@propagate_inboundswhich leads to some performance degradation. This was for example reported in https://discourse.julialang.org/t/drop-of-performances-with-julia-1-6-0-for-interpolationkernels/58085/33?u=kristoffer.carlsson.