Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore some and remove some declarations for GC API in julia.h #40775

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

OndrejSlamecka
Copy link

Access to statistics was removed but the implementation is still present and useful. jl_gc_use was removed but declaration remained.

Removed with commit b9546c8
but IMO still useful.
Implementation removed in commit 3064ef9
@imciner2
Copy link
Contributor

Are you needing to use these in an embedded case (e.g. linking against libjulia)? If so, you also need to expose them in jl_exported_funcs.inc so that the proper mapping in libjulia is made. I am not sure if these internals should actually be exposed though, so I leave that decision to others that have more knowledge of the GC system.

@OndrejSlamecka
Copy link
Author

Yes, I use these to monitor allocations in a setting with embedded Julia.

Whether these should be exposed is a fair question, however, they were exposed previously, and in fact the exports are already present (or removed in the removal case):

~/p/julia (gc-api) grep "jl_gc_get_total_bytes\|jl_gc_total_hrtime\|jl_gc_diff_total_bytes" src/jl_exported_funcs.inc
    XX(jl_gc_diff_total_bytes) \
    XX(jl_gc_get_total_bytes) \
    XX(jl_gc_total_hrtime) \
~/p/julia (gc-api) grep "jl_gc_use" src/jl_exported_funcs.inc || echo empty
empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants