Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Timing Imports] Use atomic_add! and atomic_sub! #41737

Merged
merged 1 commit into from
Aug 3, 2021
Merged

[Timing Imports] Use atomic_add! and atomic_sub! #41737

merged 1 commit into from
Aug 3, 2021

Conversation

vchuravy
Copy link
Sponsor Member

@IanButterworth
Copy link
Sponsor Member

Looks good. Though given I assume this was confirmed to be needed, could it be fixed upstream?

vtjnash
vtjnash approved these changes Jul 30, 2021
View reviewed changes
Copy link
Sponsor Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, this is why the old Atomic thing was so bad and needed to go away

@IanButterworth
Copy link
Sponsor Member

AFAIU FreeBSD CI is currently broken so I'll merge

@IanButterworth IanButterworth merged commit b686e71 into master Aug 3, 2021
@IanButterworth IanButterworth deleted the vc/atomic_timing branch August 3, 2021 15:24
@IanButterworth IanButterworth mentioned this pull request Jul 21, 2022
Merged
@tfiers tfiers mentioned this pull request Jan 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@IanButterworth IanButterworth Awaiting requested review from IanButterworth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vchuravy @IanButterworth @vtjnash