-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
separate codegen/LLVM from julia runtime #41936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,8 +13,9 @@ CNAME(name)##: SEP \ | |
| br x16 SEP \ | ||
| .cfi_endproc SEP \ | ||
|
|
||
| JL_EXPORTED_FUNCS(XX) | ||
| JL_RUNTIME_EXPORTED_FUNCS(XX) | ||
| #ifdef _OS_WINDOWS_ | ||
| JL_EXPORTED_FUNCS_WIN(XX) | ||
| JL_RUNTIME_EXPORTED_FUNCS_WIN(XX) | ||
| #endif | ||
| JL_CODEGEN_EXPORTED_FUNCS(XX) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It feels a little odd to be exporting the internal plugins from here, but otherwise, this PR seems to be mostly just renaming lots of (lots of) variables, so seems very straightforward. Not sure why it would be failing on CI. Are we accidentally linking part of libLLVM statically?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah that's true; I only really did this to reuse the mechanism. |
||
| #undef XX | ||
Uh oh!
There was an error while loading. Please reload this page.