Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use LLVM libunwind on FreeBSD #41955

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

ararslan
Copy link
Member

This switches nongnu libunwind for LLVM libunwind on FreeBSD. Doesn't fully work yet (profiling, notably).

@ararslan ararslan added the system:freebsd Affects only FreeBSD label Aug 21, 2021
@ararslan ararslan added the external dependencies Involves LLVM, OpenBLAS, or other linked libraries label Aug 21, 2021
@ararslan

This comment has been minimized.

@DilumAluthge
Copy link
Member

Any chance that this is the same bug as the one being discussed in the following threads?

  1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256864
  2. https://bugs.llvm.org/show_bug.cgi?id=50972

@ararslan
Copy link
Member Author

This now works entirely except for profiling, where the stack frames show up as unknown:

Overhead _ [+additional indent] Count File:Line; Function
=========================================================
   _101 [unknown stackframe]
   _ 101 [unknown stackframe]
   _  101 [unknown stackframe]
   _   101 [unknown stackframe]
100_    101 [unknown stackframe]
Total snapshots: 101 (100% utilization across all threads and tasks. Use the `groupby` kwarg to break down by thread and/or task)

I'm pretty far out of my depth here. If anybody is willing to help me figure this out, I would be very grateful. Otherwise I think we should mark the specific failing tests as broken on FreeBSD and merge this, as that situation is a strict improvement over what's on master currently.

@IanButterworth
Copy link
Sponsor Member

The [unknown stackframe] was a bug that is now fixed in #42226, but that means that there will now be no collected samples at all, so the issue remains

This switches nongnu libunwind for LLVM libunwind on FreeBSD.
@DilumAluthge
Copy link
Member

@ararslan Can this PR be closed now?

@ararslan
Copy link
Member Author

ararslan commented Nov 7, 2021

It might be nice to do this eventually, since it seems convenient to me for macOS, FreeBSD, and eventually Linux to use the same unwinding library. But yeah, this PR is definitely no longer a priority for me so feel free to close if you'd like.

@vtjnash
Copy link
Sponsor Member

vtjnash commented Sep 28, 2022

xref #30154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries system:freebsd Affects only FreeBSD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants