-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Use LLVM libunwind on FreeBSD #41955
base: master
Are you sure you want to change the base?
Conversation
5bc483f
to
0fcc56e
Compare
This comment has been minimized.
This comment has been minimized.
Any chance that this is the same bug as the one being discussed in the following threads? |
0fcc56e
to
0a31355
Compare
This now works entirely except for profiling, where the stack frames show up as unknown:
I'm pretty far out of my depth here. If anybody is willing to help me figure this out, I would be very grateful. Otherwise I think we should mark the specific failing tests as broken on FreeBSD and merge this, as that situation is a strict improvement over what's on master currently. |
The |
0a31355
to
ce24962
Compare
This switches nongnu libunwind for LLVM libunwind on FreeBSD.
ce24962
to
63ac63e
Compare
@ararslan Can this PR be closed now? |
It might be nice to do this eventually, since it seems convenient to me for macOS, FreeBSD, and eventually Linux to use the same unwinding library. But yeah, this PR is definitely no longer a priority for me so feel free to close if you'd like. |
xref #30154 |
This switches nongnu libunwind for LLVM libunwind on FreeBSD. Doesn't fully work yet (profiling, notably).