Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inference: relax type_more_complex for Type #42901

Merged
merged 1 commit into from
Nov 8, 2021
Merged

inference: relax type_more_complex for Type #42901

merged 1 commit into from
Nov 8, 2021

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Nov 1, 2021 •
edited
Loading

If the object is not a potential Type{...}, we can allow greater
flexibility in recursion. And for Vararg too.

Fixes #42835

@vtjnash
inference: relax type_more_complex for Type
1daaf47 
If the object is not a potential Type{...}, we can allow greater
flexibility in recursion.
@ianatol ianatol added the compiler:inference Type inference label Nov 2, 2021
@ianatol
Copy link
Member

ianatol commented Nov 2, 2021

Seems to also fix #42839

@Sacha0
Copy link
Member

Sacha0 commented Nov 4, 2021

Potentially useful for backport attempts: I attempted to backport this patch to 1.7-RC2 and found that it requires #42583; the latter backports cleanly, and then this patch backports cleanly. Regrettably #42583 introduces unhandled Vararg errors in our test suite, also seen on master.

ianatol pushed a commit to ianatol/julia that referenced this pull request Nov 5, 2021
Resolve conflicts with merging JuliaLang#42901
e43e271
ianatol pushed a commit to ianatol/julia that referenced this pull request Nov 5, 2021
@vtjnash
Backport JuliaLang#42901 without JuliaLang#42583
e99a34d
@ianatol ianatol mentioned this pull request Nov 5, 2021
Closed
@KristofferC KristofferC mentioned this pull request Nov 7, 2021
Merged
66 tasks
@KristofferC
Copy link
Sponsor Member

I've backported this to the backport-release-1.7 branch to run a PkgEval (I am assuming this will be merged here at some point).

@vtjnash vtjnash merged commit 27f579f into master Nov 8, 2021
@vtjnash vtjnash deleted the jn/42835 branch November 8, 2021 19:45
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@vtjnash @LilithHafner
inference: relax type_more_complex for Type (JuliaLang#42901)
b86a8e1 
If the object is not a potential Type{...}, we can allow greater
flexibility in recursion.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@vtjnash @LilithHafner
inference: relax type_more_complex for Type (JuliaLang#42901)
d711643 
If the object is not a potential Type{...}, we can allow greater
flexibility in recursion.
@DilumAluthge DilumAluthge mentioned this pull request Apr 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compiler:inference Type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.7-rc2] Base.promote_type inference regression
4 participants
@vtjnash @ianatol @Sacha0 @KristofferC