-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file
tests: in the "tempname with parent"
test, temporarily unset the TMPDIR
environment variable while running the test
#43012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
added
test
This change adds or pertains to unit tests
domain:filesystem
Underlying file system and functions that use it
domain:ci
Continuous integration
backport 1.6
Change should be backported to release-1.6
backport 1.7
labels
Nov 9, 2021
Seems like these tests work with TMPDIR set? |
Not on Linux. |
I meant that they should work and that it is a bug. |
… the `TMPDIR` environment variable while running the test
DilumAluthge
force-pushed
the
dpa/test-tempname-with-parent-tmpdir-env
branch
from
November 9, 2021 19:47
33c72ca
to
c24eeb6
Compare
@staticfloat Can you review this? |
staticfloat
approved these changes
Nov 9, 2021
66 tasks
95 tasks
KristofferC
removed
backport 1.6
Change should be backported to release-1.6
backport 1.7
labels
Nov 13, 2021
daviehh
pushed a commit
to daviehh/julia
that referenced
this pull request
Nov 16, 2021
… the `TMPDIR` environment variable while running the test (JuliaLang#43012) (cherry picked from commit ac2ee4d)
mkg20001
pushed a commit
to mkg20001/nixpkgs
that referenced
this pull request
Nov 29, 2021
Patches: JuliaLang/julia@v1.6.3...v1.6.4 Broken `tempname` tests disabled upstream, dropping workaround patch: JuliaLang/julia#43012 The issue itself however, persists: JuliaLang/julia#35785
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
… the `TMPDIR` environment variable while running the test (JuliaLang#43012)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
… the `TMPDIR` environment variable while running the test (JuliaLang#43012)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
domain:ci
Continuous integration
domain:filesystem
Underlying file system and functions that use it
test
This change adds or pertains to unit tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: #42995
See also: #43011
This pull request is needed for #42995.