-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impose stricter and earlier validation on ccall/cfunction types #43953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks Jameson! The changes seem sane to me, although i'm pretty unfamiliar with this code. The tests definitely seem reasonable. Thanks for making the change! 👍
The validation for ccall arguments was tightened, see JuliaLang/julia#43953
The validation for ccall arguments was tightened, see JuliaLang/julia#43953
This seems to have broken several packages that worked well so far. I am just wondering if that's intentional? From reading the issue, it sounded to me as if this was mostly there to fix things that would have crashed before, but in our case, we had a |
|
This was broken by JuliaLang/julia#43953 Fix #25
I've bisected this PR as the cause of an error similar to https://discourse.julialang.org/t/package-compiler-errors-with-system-image-too-large-message/85849. With version 1.7.x of Julia, our system image is about 1.1GB but after this PR, it fails with the |
Closes #43636