Fix next prompt detector in generate_precompile_statements
#44196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
added
backport 1.6
|
Judging by the previous commit it seems precompile statements were being missed off.. On the MacOS buildbot Previous commit: This PR: |
|
Nice |
KristofferC
reviewed
Feb 16, 2022
| occursin(PKG_PROMPT, strbuf) && break | ||
| occursin(SHELL_PROMPT, strbuf) && break | ||
| occursin(HELP_PROMPT, strbuf) && break | ||
| sleep(0.1) |
There was a problem hiding this comment.
Why is this sleep needed?
There was a problem hiding this comment.
Oh, I assume that readavailable blocks on no data but that might not be the case?
There was a problem hiding this comment.
Maybe it isn't, I didn't test it without. I just thought spinning without wait if the terminal is stalling output wasn't necessary
There was a problem hiding this comment.
Maybe we need a readuntil function that takes a regex
There was a problem hiding this comment.
yeah, I looked for that while doing this
KristofferC
pushed a commit
that referenced
this pull request
Feb 16, 2022
(cherry picked from commit c839221)
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
Feb 17, 2022
KristofferC
pushed a commit
that referenced
this pull request
Feb 19, 2022
(cherry picked from commit c839221)
50 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
KristofferC
pushed a commit
that referenced
this pull request
Feb 23, 2022
(cherry picked from commit c839221)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit c839221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
generate_precompile_statementsit turns out the repeatedly overprinted>chars from thePkg.precompileprogress bar were being interpreted as the next prompts.. making the precompile statement generator process race to the end and crashing the end of the process. I'm not sure whether that means the scripts afterwards failed to get precompile statements generated.This was confirmed by setting
debug_output = stdout