Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: added example to the function hasfield. (From #41782) #44274

Merged
merged 3 commits into from
Feb 23, 2022

Conversation

ViralBShah
Copy link
Member

Try to land #41782 addressing some of the comments in there by @mcabbott.

…he whitespace problem..

Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
(cherry picked from commit 9c0e5b0d186ea95a06d5b0bdc4bc19d1a17b444d)
@ViralBShah ViralBShah added the domain:docs This change adds or pertains to documentation label Feb 20, 2022
@mcabbott
Copy link
Contributor

This looks identical to #41782? I have completely forgotten but my comment #41782 (comment) was about whether false means "it doesn't have such a field" or just the opposite of "there is sure to be such a field".

@ViralBShah
Copy link
Member Author

Yes, it is identical, but I figured I needed to be able to modify it and do some rebasing and stuff - and wasn't sure if I could do it on the user's fork. Hence created a branch here.

@ViralBShah
Copy link
Member Author

doctest fails - so can't merge this without fixing it.

base/reflection.jl Outdated Show resolved Hide resolved
@vtjnash vtjnash added the status:merge me PR is reviewed. Merge when all tests are passing label Feb 22, 2022
@aviatesk aviatesk merged commit aa2421d into master Feb 23, 2022
@aviatesk aviatesk deleted the vs/hasfield-doc branch February 23, 2022 03:36
@ViralBShah ViralBShah added the backport 1.8 Change should be backported to release-1.8 label Feb 24, 2022
@DilumAluthge DilumAluthge removed the status:merge me PR is reviewed. Merge when all tests are passing label Feb 25, 2022
staticfloat pushed a commit to JuliaCI/julia-buildkite-testing that referenced this pull request Mar 2, 2022
…g#41782) (JuliaLang#44274)

Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
(cherry picked from commit 9c0e5b0d186ea95a06d5b0bdc4bc19d1a17b444d)
KristofferC pushed a commit that referenced this pull request Mar 3, 2022
…44274)

Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
(cherry picked from commit 9c0e5b0d186ea95a06d5b0bdc4bc19d1a17b444d)
(cherry picked from commit aa2421d)
@KristofferC KristofferC mentioned this pull request Mar 3, 2022
47 tasks
KristofferC pushed a commit that referenced this pull request Mar 7, 2022
…44274)

Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
(cherry picked from commit 9c0e5b0d186ea95a06d5b0bdc4bc19d1a17b444d)
(cherry picked from commit aa2421d)
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
…g#41782) (JuliaLang#44274)

Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
(cherry picked from commit 9c0e5b0d186ea95a06d5b0bdc4bc19d1a17b444d)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants