[CompilerSupportLibraries_jll] Update to v0.5.2 #44487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
domain:building
giordano
added
backport 1.7
backport 1.8
giordano
force-pushed
the
mg/csl
branch
2 times, most recently
from
99ebcb4
to
35a4196
Compare
giordano
commented
Mar 6, 2022
| @@ -1,4 +1,4 @@ | |||
| # -*- mode: makefile-gmake -*- | |||
| # -*- mode: makefile -*- | |||
There was a problem hiding this comment.
Thanks to Emacs, now we have proper syntax highlighting in GitHub for this file 🙂
The main difference since previous version should be the libraries for aarch64-apple-darwin, which are based on a more recent version of the GCC fork for this platform. There are a couple of notable ABI changes here: * `libgcc_s` is now called `libgcc_s.1.1.dylib` instead of `libgcc_s.2.dylib` * there is now `libquadmath.0.dylib` for this platform, which was missing before.
giordano
commented
Mar 6, 2022
Comment on lines
+207
to
+211
| ifeq ($(APPLE_ARCH),arm64) | ||
| $(eval $(call symlink_system_library,CSL,libgcc_s,1.1)) | ||
| else | ||
| $(eval $(call symlink_system_library,CSL,libgcc_s,1)) | ||
| endif |
There was a problem hiding this comment.
@fxcoudert can you please try this out now? Ref: #44435 (comment)
There was a problem hiding this comment.
I confirm that this change works for me.
47 tasks
staticfloat
approved these changes
Mar 8, 2022
KristofferC
pushed a commit
that referenced
this pull request
Mar 11, 2022
The main difference since previous version should be the libraries for aarch64-apple-darwin, which are based on a more recent version of the GCC fork for this platform. There are a couple of notable ABI changes here: * `libgcc_s` is now called `libgcc_s.1.1.dylib` instead of `libgcc_s.2.dylib` * there is now `libquadmath.0.dylib` for this platform, which was missing before. (cherry picked from commit cb2fa5d)
KristofferC
pushed a commit
that referenced
this pull request
Apr 19, 2022
The main difference since previous version should be the libraries for aarch64-apple-darwin, which are based on a more recent version of the GCC fork for this platform. There are a couple of notable ABI changes here: * `libgcc_s` is now called `libgcc_s.1.1.dylib` instead of `libgcc_s.2.dylib` * there is now `libquadmath.0.dylib` for this platform, which was missing before. (cherry picked from commit cb2fa5d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main difference since previous version should be the libraries for
aarch64-apple-darwin, which are based on a more recent version of the GCC fork
for this platform. There are a couple of notable ABI changes here:
libgcc_sis now calledlibgcc_s.1.1.dylibinstead oflibgcc_s.2.dylib(ref: System library build of Julia master fails on ARM macOS #44435)libquadmath.0.dylibfor this platform, which was missingbefore.
Usual memo to self, update the library:
stdlib/CompilerSupportLibraries_jll/Project.toml,make -f contrib/refresh_checksums.mk -j csland remove the old checksums from the updated file deps/checksums/compilersupportlibraries