effects: define Core.Compiler.infer_effects
#44822
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkf
reviewed
Apr 1, 2022
aviatesk
force-pushed
the
avi/infer_effects
branch
2 times, most recently
from
0d2c6b8
to
1604714
Compare
aviatesk
commented
Apr 4, 2022
Comment on lines
+2076
to
+2081
| if !isempty(sv.pclimitations) | ||
| # conservatively express uncertainty of this result | ||
| return CallMeta(Effects, false) | ||
| end |
There was a problem hiding this comment.
Are there any other cases where we need to take some uncertainty into account?
I think the current implementation is okay as we exclude case when any of input arguments isn't fully known.
There was a problem hiding this comment.
The case that are uncertain are known to be uncomputable presently (possibly always / fundamentally?), which is why this is a bad candidate for an inference tfunc, but a good candidate for a special-inliner.
This new reflection utility is similar to `Core.Compiler.return_type` but for the effect analysis. It comes with its own tfunc and similar compiler optimizations so that we can fold inferred effects at compiler time when possible (albeit it is as unreliable as `Core.Compiler.return_type`).
aviatesk
force-pushed
the
avi/infer_effects
branch
from
1604714
to
f07dea9
Compare
|
I think this has been added already now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new reflection utility is similar to
Core.Compiler.return_typebutfor the effect analysis. It comes with its own tfunc and similar compiler
optimizations so that we can fold inferred effects at compiler time when
possible (albeit it is as unreliable as
Core.Compiler.return_type).For now
Core.Compiler.infer_effectsis folded at compile time only whenall the input arguments are fully known.