New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: versioned libm
- symlink libpthread
- fix symlinks
#45918
Open
t-bltg
wants to merge
2
commits into
JuliaLang:master
Choose a base branch
from
t-bltg:libm
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bltg
force-pushed
the
libm
branch
3 times, most recently
from
July 3, 2022 20:37
a32d6f4
to
e2e14cb
Compare
inkydragon
added
the
domain:building
Build system, or building Julia or its dependencies
label
Jul 4, 2022
inkydragon
reviewed
Jul 4, 2022
inkydragon
reviewed
Jul 4, 2022
t-bltg
force-pushed
the
libm
branch
5 times, most recently
from
July 7, 2022 06:26
0fbe162
to
733bfee
Compare
vtjnash
reviewed
Jul 7, 2022
t-bltg
force-pushed
the
libm
branch
2 times, most recently
from
July 13, 2022 16:34
1d8554f
to
f62a681
Compare
t-bltg
force-pushed
the
libm
branch
3 times, most recently
from
August 8, 2022 08:32
746ff90
to
787e2a6
Compare
@staticfloat or @vtjnash: is there any objection for this PR to go in ? |
Is this good to merge? |
It's ready on my side (I've been using this PR in my builds since at least a year on ubuntu). |
After #42299, perhaps we won't need libm linking at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) There is no apparent reason to use an unversioned
libm.so
when settingUSE_SYSTEM_LIBM = 1
, and on some distributions,libm.so
is a valid linker script thus failing julia at runtime with the following error:E.g. on
ubuntu 22.04
:We already use versioned compiler support libraries (CSL), so versioning
libm
makes it consistent with CSL.When using
glibc
, try to detect the ABI version inMakefile
as it is currently done forlibgfortran
, falling back to version6
(unchanged since 1997) if needed.b) When setting
USE_SYSTEM_CSL = 1
, also try to symlinklibpthread
as it is listed in the private libs. Is there a reason not to do this ?c) Also, prevent nesting symlinks resulting in a copy error on
make install
when the destination already exists and multiplemake
commands have been thrown before.Tested locally using
USE_SYSTEM_LIBM = 1
andUSE_SYSTEM_CSL = 1
: test suite is green.