Replace BUNDLE_DEBUG_LIBS with make install JULIA_BUILD_MODE=debug.
#46320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
added
the
domain:building
|
The goal of this is to use PkgEval with a debug build (buildflags are put in @nanosoldier |
staticfloat
approved these changes
Aug 11, 2022
|
Your package evaluation job has completed - possible issues were detected. A full report can be found here. |
|
This needed some more fixes, here and in PkgEval: @nanosoldier |
|
Your package evaluation job has completed - possible issues were detected. A full report can be found here. |
|
Looks like this works well. |
yuyichao
added a commit
to archlinuxcn/repo
that referenced
this pull request
Aug 17, 2022
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
Replaces BUNDLE_DEBUG_LIBS, and fixes fixup-libstdc++.sh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46317. I don't think BUNDLE_DEBUG_LIBS was used, or even documented, and for PkgEval it makes more sense to pick one or the other (and it simplifies the Makefile). Currently mostly implemented using conditionals, but could be cleaned up. (using
$(JULIA_EXECUTABLE_$(JULIA_BUILD_MODE))-like tricks).