Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map of unequal length bitarray #47013

Merged
merged 24 commits into from
Oct 13, 2022

Conversation

Moelf
Copy link
Sponsor Contributor

@Moelf Moelf commented Oct 2, 2022

fix #47011

  • fix bit_map!
  • add bit array test for unequal length

@CameronBieganek
Copy link
Contributor

That was fast. 🙂

base/bitarray.jl Outdated Show resolved Hide resolved
base/bitarray.jl Outdated Show resolved Hide resolved
base/bitarray.jl Outdated Show resolved Hide resolved
Moelf and others added 2 commits October 3, 2022 00:53
Co-authored-by: N5N3 <2642243996@qq.com>
@Moelf Moelf requested a review from N5N3 October 3, 2022 13:22
base/bitarray.jl Outdated Show resolved Hide resolved
base/bitarray.jl Outdated Show resolved Hide resolved
base/bitarray.jl Outdated Show resolved Hide resolved
@N5N3 N5N3 added the domain:arrays [a, r, r, a, y, s] label Oct 4, 2022
Moelf and others added 4 commits October 3, 2022 23:07
Co-authored-by: N5N3 <2642243996@qq.com>
Co-authored-by: N5N3 <2642243996@qq.com>
base/bitarray.jl Outdated Show resolved Hide resolved
test/bitarray.jl Outdated Show resolved Hide resolved
Moelf and others added 2 commits October 4, 2022 11:24
Co-authored-by: Cameron Bieganek <8310743+CameronBieganek@users.noreply.github.com>
base/bitarray.jl Outdated Show resolved Hide resolved
base/bitarray.jl Outdated Show resolved Hide resolved
Moelf and others added 3 commits October 4, 2022 13:37
Co-authored-by: Cameron Bieganek <8310743+CameronBieganek@users.noreply.github.com>
Co-authored-by: Cameron Bieganek <8310743+CameronBieganek@users.noreply.github.com>
@N5N3 N5N3 merged commit 01310a9 into JuliaLang:master Oct 13, 2022
@Moelf Moelf deleted the map_of_unequal_length_bitarray branch October 13, 2022 13:49
oscardssmith added a commit that referenced this pull request Aug 5, 2023
KristofferC pushed a commit that referenced this pull request Aug 10, 2023
fixes #50780 caused by #47013.

(cherry picked from commit 3e04129)
KristofferC pushed a commit that referenced this pull request Aug 10, 2023
fixes #50780 caused by #47013.

(cherry picked from commit 3e04129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:arrays [a, r, r, a, y, s]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map! errors on a BitVector when the destination is longer than the source
3 participants