Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lattice: fix minor lattice issues #47570

Merged
merged 1 commit into from
Nov 16, 2022
Merged

lattice: fix minor lattice issues #47570

merged 1 commit into from
Nov 16, 2022

Conversation

aviatesk
Copy link
Sponsor Member

I found some lattice issues when implementing MustAlias under the new extendable lattice system in another PR.

@aviatesk aviatesk requested a review from Keno November 15, 2022 02:33
@aviatesk
Copy link
Sponsor Member Author

@nanosoldier runbenchmarks("inference", vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@aviatesk aviatesk force-pushed the avi/lattice-fixes branch 3 times, most recently from f11862d to 137ae45 Compare November 15, 2022 03:55
@JuliaLang JuliaLang deleted a comment from nanosoldier Nov 15, 2022
@JuliaLang JuliaLang deleted a comment from nanosoldier Nov 15, 2022
@aviatesk
Copy link
Sponsor Member Author

@nanosoldier runbenchmarks("inference", vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - no performance regressions were detected. A full report can be found here.

I found some lattice issues when implementing `MustAlias` under the new
extendable lattice system in another PR.
@aviatesk aviatesk merged commit ee0f3fc into master Nov 16, 2022
@aviatesk aviatesk deleted the avi/lattice-fixes branch November 16, 2022 00:27
KristofferC pushed a commit that referenced this pull request Feb 20, 2023
I found some lattice issues when implementing `MustAlias` under the new
extendable lattice system in another PR.

(cherry picked from commit ee0f3fc)
KristofferC pushed a commit that referenced this pull request Feb 20, 2023
I found some lattice issues when implementing `MustAlias` under the new
extendable lattice system in another PR.

(cherry picked from commit ee0f3fc)
KristofferC pushed a commit that referenced this pull request Feb 20, 2023
I found some lattice issues when implementing `MustAlias` under the new
extendable lattice system in another PR.

(cherry picked from commit ee0f3fc)
KristofferC pushed a commit that referenced this pull request Feb 21, 2023
I found some lattice issues when implementing `MustAlias` under the new
extendable lattice system in another PR.

(cherry picked from commit ee0f3fc)
KristofferC pushed a commit that referenced this pull request Feb 21, 2023
I found some lattice issues when implementing `MustAlias` under the new
extendable lattice system in another PR.

(cherry picked from commit ee0f3fc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants