Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix confusing doc of bind on Tasks and Sockets #47613

Closed
wants to merge 2 commits into from
Closed

Fix confusing doc of bind on Tasks and Sockets #47613

wants to merge 2 commits into from

Conversation

udohjeremiah
Copy link
Contributor

@udohjeremiah udohjeremiah commented Nov 17, 2022 •
edited
Loading

This fixes #45359

@udohjeremiah udohjeremiah added the domain:docs This change adds or pertains to documentation label Nov 17, 2022
@KristofferC
Copy link
Sponsor Member

Please use descriptive PR titles and commit messages.

@udohjeremiah
Copy link
Contributor Author

These changes are pertaining to docs, and the issue tagged with the PR along with the changes made, easily makes clear the message. I feel adding my own words will complicate things, anyways good recommendation.

@udohjeremiah udohjeremiah changed the title Fix #45359 Fix confusing doc of bind on Tasks and Sockets Nov 17, 2022
Keno
Keno approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible these just shouldn't be the same generic method, but regardless, this change seems fine and we probably can't do anything about it until 2.0 anyway

@udohjeremiah udohjeremiah closed this by deleting the head repository Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
domain:docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove confusing doc of bind
4 participants
@udohjeremiah @KristofferC @Keno @ViralBShah