[CompilerSupportLibraries_jll] Upgrade to v1.0.2 and install libsspdll.a on Windows
#47864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
domain:building
vchuravy
approved these changes
Dec 10, 2022
|
Is that something commonly available? We don't want installations and builds to break if they just happen to be using a newer compiler (than CSL) with commonly default flags. |
|
I didn't change any flags in gcc, only what files we put into the CSL tarballs. |
|
Note also this is the import library for |
vchuravy
force-pushed
the
vc/external_functions
branch
from
2d78f02
to
0a8e063
Compare
…dll.a` on Windows The new build provides the import library for `libssp` on Windows, instead of the static library.
vchuravy
force-pushed
the
mg/csl-1.0.2
branch
from
c189428
to
4f607af
Compare
vchuravy
added
the
status:merge me
giordano
removed
the
status:merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new build provides the import library for
libsspon Windows, instead of the static library.@vchuravy I don't know if this should target
masteror your branch. Since you'd have to edit the Makefile anyway maybe this can target your branch?