RFC: add default dims
to eachslice
#48108
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder if
eachslice
should have a default of the last dimension.In python you can do
for mat in batch
to iterate a 3D array by getting its slices... the ones which make sense for row-major arrays. With this, something likefor mat in eachslice(batch)
would iterate the slices which make sense for column-major arrays.Edit: closes #54626
Extend to
eachcol
? (Edit: removed for now)Less obviously, we could also extend
eachcol
to always give a slice along the first dimension. Thenfor col in eachcol(batch)
would return dense 1D views for any higher-dim Array.For symmetry we should then extend
eachrow
; note that on vectors it currently picks the 2nd (trivial) dimension, so I think that's what it would have to do always: