stop using rand(lo:hi) for QuickerSort pivot selection
#48241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilithHafner
added
domain:randomness
oscardssmith
approved these changes
Jan 11, 2023
fredrikekre
reviewed
Jan 11, 2023
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
LilithHafner
added
backport 1.9
LilithHafner
removed
the
status:merge me
KristofferC
pushed a commit
that referenced
this pull request
Jan 13, 2023
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com> (cherry picked from commit 793eaa3)
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see discussion here: #45222 (comment)
fixes #48230
takes sorting out of the discussion in #48069
This is a regression in how easy it is to construct a pathological input with respect to master and julia-1.9.0-beta2, but not w.r.t. 1.8.5.
Also fix a comment that I noticed had gone stale.