make insert_extension_triggers idempotent
#48586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 9, 2023
KristofferC
force-pushed
the
kc/ext_idem
branch
from
e43f82e
to
732c3bc
Compare
KristofferC
force-pushed
the
kc/ext_idem
branch
from
732c3bc
to
6bd658e
Compare
KristofferC
added
status:merge me
oscardssmith
removed
the
status:merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vtjnash said he had seen cases where the same extension was ready to be triggered multiple times due to multiple calls to
insert_extension_triggers. This should make the function idempotent so that cannot happen.