Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for use 60% of constrained/total system memory #48614

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

gbaraldi
Copy link
Member

@gbaraldi gbaraldi commented Feb 9, 2023

Remove the high watermark logic because it doesn't really make sense and allow for use of 60% of system memory.
Should fix #48473

@giordano giordano added the GC Garbage collector label Feb 9, 2023
src/gc.c Outdated Show resolved Hide resolved
@KristofferC
Copy link
Sponsor Member

allow for use of 60% of system memory.

Out of curiosity, what's the reason for this? If I have a dedicated computer for running a julia workload, will it only try use 60% of the memory before it goes hardcore GC mode? Is the solution to override that with --heap-size-hint in case you want to use the full machine?

KristofferC pushed a commit that referenced this pull request Feb 20, 2023
Remove the high watermark logic, because it doesn't really make sense,
and allow for use of 60% of system memory before aggressive GC kicks in.

Should fix #48473

(cherry picked from commit 500f561)
@gbaraldi
Copy link
Member Author

It was a bit arbitrary. And it's yes to both questions. It will start to do more full GCs when reaching the 60% threshold, and yes you can change it with heapsize-hint

@KristofferC
Copy link
Sponsor Member

60% feels a bit conservative? So if you run Julia on a cluster you kind of only get half the memory you "pay" for?

@gbaraldi
Copy link
Member Author

Thinking about it, maybe we can be a bit smarter and have like a curve. So in a memory constrained system we use something like 60%, but on a cluster with 256GB we use like 250.

KristofferC pushed a commit that referenced this pull request Feb 20, 2023
Remove the high watermark logic, because it doesn't really make sense,
and allow for use of 60% of system memory before aggressive GC kicks in.

Should fix #48473

(cherry picked from commit 500f561)
KristofferC pushed a commit that referenced this pull request Feb 21, 2023
Remove the high watermark logic, because it doesn't really make sense,
and allow for use of 60% of system memory before aggressive GC kicks in.

Should fix #48473

(cherry picked from commit 500f561)
KristofferC pushed a commit that referenced this pull request Feb 21, 2023
Remove the high watermark logic, because it doesn't really make sense,
and allow for use of 60% of system memory before aggressive GC kicks in.

Should fix #48473

(cherry picked from commit 500f561)
KristofferC pushed a commit that referenced this pull request Feb 21, 2023
Remove the high watermark logic, because it doesn't really make sense,
and allow for use of 60% of system memory before aggressive GC kicks in.

Should fix #48473

(cherry picked from commit 500f561)
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GC Garbage collector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pathological GC time on M1 mac
4 participants