Add world argument to jl_create_native. #48746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Feb 21, 2023
KristofferC
pushed a commit
that referenced
this pull request
Feb 21, 2023
(cherry picked from commit 0975906)
KristofferC
pushed a commit
that referenced
this pull request
Feb 21, 2023
(cherry picked from commit 0975906)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
jl_create_nativejust uses the current world age to emit code for. However, with #48611, we'll be able to have GPUCompiler.jl properly respect world ages. That includes the ability to generate code for a previous world, so we need a way to invokejl_create_nativefor a specific world.Without this, we'll need a horrible hack, so ideally I'd like this to be part of 1.9.