add default constructors for AbstractRange #48894
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inkydragon
reviewed
Mar 10, 2023
There was a problem hiding this comment.
Is it necessary to add constructors for abstract types?
julia> methods(AbstractRange)
# 0 methods for type constructor
julia> supertype(AbstractRange)
AbstractVector (alias for AbstractArray{T, 1} where T)
julia> methods(AbstractVector)
# 0 methods for type constructor
julia> supertype(AbstractVector)
Any
|
As you can see from added tests, it does eltype conversion for general ranges. |
putianyi889
added a commit
to putianyi889/PTYQoL.jl
that referenced
this pull request
Nov 5, 2023
vtjnash
added
the
status:forget me not
|
@putianyi889 This seems like a good idea. Is this ready from your side? |
confirm.
not sure how many. maybe add 2-3 segments to every conversion test? |
dlfivefifty
reviewed
Mar 25, 2024
dlfivefifty
reviewed
Mar 25, 2024
Co-authored-by: Sheehan Olver <solver@mac.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related posts
convert(AbstractArray{T}, ::AbstractRange)and variants #27138