Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "add morespecific rule for Type{Union{}}" #49457

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Revert "add morespecific rule for Type{Union{}}" #49457

merged 1 commit into from
Apr 22, 2023

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Apr 21, 2023 •
edited by giordano
Loading

Reverts #49349

Let's see if reverting fixes analyzegc.

Fix #49453.

@DilumAluthge DilumAluthge added the kind:revert This reverts a previously merged PR. label Apr 21, 2023
@DilumAluthge
Copy link
Member Author

analyzegc is red on master and is green on this PR. So I think we're good to proceed with this revert. cc: @vtjnash

Note: the failure of build on aarch64-apple-darwin is a known issue that is not related to this PR. It's related to the new Apple Silicon Mac Minis that @staticfloat is currently working on setting up. See e.g. JuliaCI/julia-buildkite#296

@DilumAluthge DilumAluthge merged commit 57b68f2 into master Apr 22, 2023
@DilumAluthge DilumAluthge deleted the revert-49349-jn/morespecific-bottom branch April 22, 2023 04:51
@DilumAluthge DilumAluthge mentioned this pull request Apr 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind:revert This reverts a previously merged PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recent commit introduced a failure in analyzegc
1 participant
@DilumAluthge