Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.9] Avoid usage of jl_error() in check_cmdline() #49486

Merged
merged 1 commit into from
Apr 24, 2023
Merged

[release-1.9] Avoid usage of jl_error() in check_cmdline() #49486

merged 1 commit into from
Apr 24, 2023

Conversation

staticfloat
Copy link
Sponsor Member

This is the same as #45765 where we use jl_error() too early to get backtraces, but too late to fail the supposed guard if statement that should prevent us from trying to take a backtrace. X-ref: #45847

(cherry picked from commit fa21589)

@staticfloat
Avoid usage of jl_error() in check_cmdline()
3f42af0 
This is the same as #45765 where
we use `jl_error()` too early to get backtraces, but too late to fail
the supposed guard `if` statement that should prevent us from trying to
take a backtrace.  X-ref: #45847

(cherry picked from commit fa21589)
@staticfloat staticfloat changed the title Avoid usage of jl_error() in check_cmdline() [release-1.9] Avoid usage of jl_error() in check_cmdline() Apr 24, 2023
@staticfloat staticfloat merged commit 0a374d5 into backports-release-1.9 Apr 24, 2023
@staticfloat staticfloat deleted the sf/backport_win_hang_fix branch April 24, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@staticfloat