Ensure Distributed workers inherit threads spec properly #49942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
approved these changes
May 23, 2023
|
Happy to drop it. I followed the pattern I used when fixing this for Pkg.jl. I don't know if the convention is different? |
|
Yeah, I guess the main difference is Pkg.jl lives in its own repo, so maybe it's used a little more independently? vs. Distributed only lives in JuliaLang/julia, so it's more like base/ code? Probably fine to leave in, but my main point is that I don't think we need it because since it lives here, it's always matching "tip" of JuilaLang/julia. |
|
My bad, yeah we don't need the version check. That should be removed from Pkg |
|
Removed from here. |
vtjnash
approved these changes
May 24, 2023
KristofferC
pushed a commit
that referenced
this pull request
Jun 27, 2023
(cherry picked from commit aea56a9)
KristofferC
pushed a commit
that referenced
this pull request
Jun 27, 2023
(cherry picked from commit aea56a9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that there are threadpools, we cannot simply use
Base.JLOptions().nthreadsto get the threads spec for Distributed workers.