add specialized reverse implementation for NTuple
#50113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a specialized version of `reverse` for NTuple using a simple constructor. 1.9: ``` julia> a = tuple(rand(Int, 256)...); julia> @benchmark reverse($a) BenchmarkTools.Trial: 7099 samples with 1 evaluation. Range (min … max): 611.280 μs … 5.698 ms ┊ GC (min … max): 0.00% … 0.00% Time (median): 670.392 μs ┊ GC (median): 0.00% Time (mean ± σ): 700.950 μs ± 144.952 μs ┊ GC (mean ± σ): 1.37% ± 5.70% ▃▄██▇▆▆▆▆▄▂ ▂ ▇███████████▇▇▆▄▇█▅▅▅▃▄▁▁▁▁▃▄▄▁▁▁▃▁▃▁▁▄▃▄▅▆▅▆▆▅▅▆▇▆▆▇▇▇█▇▆▇▇▆ █ 611 μs Histogram: log(frequency) by time 1.33 ms < Memory estimate: 794.42 KiB, allocs estimate: 33663. ``` This commit: ``` julia> @benchmark reverse($a) BenchmarkTools.Trial: 10000 samples with 995 evaluations. Range (min … max): 26.252 ns … 52.545 ns ┊ GC (min … max): 0.00% … 0.00% Time (median): 26.285 ns ┊ GC (median): 0.00% Time (mean ± σ): 26.578 ns ± 0.940 ns ┊ GC (mean ± σ): 0.00% ± 0.00% █▆▂ ▁ ▁ ████▆▅▆▅▄▄▄▂▃▄███▇▆▆▆▅▆▄▅▅▆█▇▆▄▅▆▆▅▆██▅▅▅▄▅▅▄▅▄▅▅▅▄▅▃▅▂▄▄██ █ 26.3 ns Histogram: log(frequency) by time 30.2 ns < Memory estimate: 0 bytes, allocs estimate: 0. ```
sjkelly
changed the title
reverse implementation for NTuplereverse implementation for NTuple
sjkelly
changed the title
reverse implementation for NTuplereverse implementation for NTuple
oscardssmith
approved these changes
Jun 8, 2023
|
Many other tuple functions have a limit size for when they stop specialising. Shouldn't that be the case here too? |
|
Yes, that happens automatically with the non- |
|
The other |
Moelf
reviewed
Feb 6, 2024
|
|
||
| # Specialized extensions for NTuple | ||
| function reverse(t::NTuple{N}) where N | ||
| ntuple(Val{N}()) do i |
There was a problem hiding this comment.
this is better than Val(N)?
There was a problem hiding this comment.
It doesn't matter. Usually Val(N) is preferred as it is more concise, but it desugars to effectively the same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a specialized version of
reversefor NTupleusing a simple constructor.
1.9:
This commit: