Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unquoted symbols for threadpool in Threads.@spawn #50182

Merged
merged 3 commits into from Jun 15, 2023
Merged

Allow unquoted symbols for threadpool in Threads.@spawn #50182

merged 3 commits into from Jun 15, 2023

Conversation

IanButterworth
Copy link
Sponsor Member

Fixes #50165

julia> fetch(Threads.@spawn :interactive Threads.threadpool())
:interactive

julia> tp = :interactive
:interactive

julia> fetch(Threads.@spawn tp Threads.threadpool())
:interactive

Co-authored with @jpsamaroo

@IanButterworth @jpsamaroo
Allow quoted symbols for threadpool in Threads.@spawn
6970003 
Co-Authored-By: Julian Samaroo <jpsamaroo@gmail.com>
@IanButterworth IanButterworth added the domain:multithreading Base.Threads and related functionality label Jun 15, 2023
@IanButterworth IanButterworth changed the title Allow quoted symbols for threadpool in Threads.@spawn Allow unquoted symbols for threadpool in Threads.@spawn Jun 15, 2023
@IanButterworth
Copy link
Sponsor Member Author

@KristofferC I think this is more of a bugfix than a feature. Would backport-1.9 be reasonable?

@IanButterworth @jpsamaroo
fix unrecognized threadpool name
98748b1 
Co-Authored-By: Julian Samaroo <jpsamaroo@gmail.com>
@jpsamaroo jpsamaroo requested a review from kpamnany June 15, 2023 15:53
@IanButterworth @jpsamaroo
Update base/threadingconstructs.jl
7f6165e 
Co-authored-by: Julian Samaroo <jpsamaroo@gmail.com>
@vchuravy vchuravy added the backport 1.9 Change should be backported to release-1.9 label Jun 15, 2023
@IanButterworth IanButterworth merged commit 9d1ac97 into JuliaLang:master Jun 15, 2023
7 checks passed
@IanButterworth IanButterworth deleted the ib/spawn_quote_tp branch June 15, 2023 18:14
KristofferC pushed a commit that referenced this pull request Jun 26, 2023
@IanButterworth @KristofferC
Allow unquoted symbols for threadpool in Threads.@spawn (#50182)
461d17d 
Co-authored-by: Julian Samaroo <jpsamaroo@gmail.com>
(cherry picked from commit 9d1ac97)
@KristofferC KristofferC mentioned this pull request Jun 26, 2023
Merged
36 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jul 10, 2023
This was referenced Mar 12, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpsamaroo jpsamaroo jpsamaroo left review comments

@vchuravy vchuravy vchuravy approved these changes

@kpamnany kpamnany Awaiting requested review from kpamnany

Assignees
No one assigned
Labels
domain:multithreading Base.Threads and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow unquoted symbols for threadpool in Threads.@spawn
4 participants
@IanButterworth @vchuravy @jpsamaroo @KristofferC