Emphasize the default base of multiversioning in the documentation, a… #50211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd discourage the implicit default base
pchintalapudi
added
compiler:codegen
vchuravy
approved these changes
Jun 19, 2023
|
Fixes #50148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd discourage the implicit default base.
Setting
JULIA_CPU_TARGET=skylake;broadwellas done in #50148 is inadvisable, as this results in an image where the uncloned functions use skylake features but cloned functions use broadwell features. The more likely intended meaning here is to have setclone_allfor broadwell, so we should make this default more obvious while also encouraging explicitly specifying clone_all/base target index when necessary.