Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initialize jl_n_markthreads and jl_n_sweepthreads to be consistent with no parallel GC on bootstrap #50332

Merged
merged 1 commit into from
Jun 28, 2023
Merged

initialize jl_n_markthreads and jl_n_sweepthreads to be consistent with no parallel GC on bootstrap #50332

merged 1 commit into from
Jun 28, 2023

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Jun 28, 2023

Fixes #50327.

@vchuravy
Copy link
Sponsor Member

So the issue is that we were in a partially initialized state?

@d-netto
Copy link
Member Author

d-netto commented Jun 28, 2023

We were already disabling parallel GC on bootstrap before. This PR just makes sure that the variables jl_n_markthreads and jl_n_sweepthreads introduced in #48969 are consistent with this.

@d-netto d-netto changed the title no parallel GC on bootstrap initialize jl_n_markthreads and jl_n_sweepthreads to be consistent with no parallel GC on bootstrap Jun 28, 2023
@oscardssmith oscardssmith added GC Garbage collector kind:bugfix This change fixes an existing bug status:merge me PR is reviewed. Merge when all tests are passing labels Jun 28, 2023
@d-netto d-netto merged commit d67b899 into master Jun 28, 2023
10 checks passed
@d-netto d-netto deleted the dcn/no-parallel-gc-on-build branch June 28, 2023 20:25
@oscardssmith oscardssmith removed the status:merge me PR is reviewed. Merge when all tests are passing label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
GC Garbage collector kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building nightly with multiple Julia GC threads causes segfault
3 participants
@d-netto @vchuravy @oscardssmith