-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update command-line-interface.md #50605
Conversation
I have mentioned the missing argument in Command-line Interface page.
Sir I have made the changes please check if it could be merged . |
Closes #50588 |
Why didn't this merge? |
@prbzrg I guess, I closed it by mistake earlier. So can it be merged now |
I'm ok with this merged (as is). The MemBalancer is no longer in, that I hoped would make this redundant (maybe later when back in). I read "Forces garbage collection" as doing that ensuring staying within limit, but it only means does the GC, and it might still end up over the limit. |
It's a copy from Lines 225 to 227 in ef3bf66
so any changes should apply to both. |
The just merge as is. It's correct, I made a review comment about it seemingly incorrect, but I was wrong. I was hoping we don't need this hint and educating users of it, and hopefully it will become redundant. |
bump. |
Duplicate of PR #50480 |
I have mentioned the missing argument in Command-line Interface page.