Document and clean up CodegenParams #51140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add documentation to CodegenParams fields per request in #51123 - Fix compare_cgparams which hadn't been updated for recent additions - Remove unused and untested generic_context The latter was a codegen option that I added, but eventually ended up not using anywhere, so remove it for the time being. That said, I may end up in a situation where I need it again in the very near future, so I may end up eating my words here, but if I need to put it back, I'll include a test at least ;).
maleadt
approved these changes
Sep 1, 2023
vtjnash
reviewed
Sep 1, 2023
| gcstack_arg::Cint | ||
|
|
||
| """ | ||
| If enabled, use the Julia PLT mechanism to support lazy-resolution of `ccall` |
There was a problem hiding this comment.
LGTM
As a side-note: The PLT mechanism here is equivalent to using an ifunc alias (where the target is a weak symbol or dlsym result), so it is not strictly just for the feature, we just don't trust that the platform linker will handle those well, and we know it is possible to always implement them better for any environment: https://maskray.me/blog/2021-01-18-gnu-indirect-function#alternative
vtjnash
added
domain:docs
DilumAluthge
removed
the
status:merge me
aviatesk
reviewed
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter was a codegen option that I added, but eventually ended up not using anywhere, so remove it for the time being. That said, I may end up in a situation where I need it again in the very near future, so I may end up eating my words here, but if I need to put it back, I'll include a test at least ;).