remove special case for the no-op first statement in fully_eliminated
#51227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the special case is no longer needed. If this gets broken by future changes, we should fix it or mark the test cases as `broken`.
aviatesk
commented
Sep 7, 2023
aviatesk
commented
Sep 7, 2023
|
It looks like maybe this was to make the test run correctly with |
|
I don't think so because this tweak was introduced since a change on the CFG transformation introduced spurious no-op statement (, which seems to have been fixed lately, xref: #50924), and AFAIU our |
|
It does run, though many of these tests fail https://buildkite.com/julialang/julia-master-scheduled/builds/485#018a6eac-3dcc-48c3-bd92-915204cd3903 |
|
When we are going to fix the failures in coverage test runt, I'd like to add an explicit check of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the special case is no longer needed. If this gets broken by future changes, I would like fix it or mark the test cases as
broken.