tweak the error printed for PrecompileError to indicate that it doesn't have to be due to __precompile__(false)
#51367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sn't have to be due to `__precompile__(false)`
KristofferC
added
the
domain:error messages
|
I guess this is an improvement/stop gap for users that see this message, but it doesn't fix the underlying issue #51299 |
|
I just want people to stop hunting from a |
IanButterworth
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Given PrecompilableError is going to be used for more reasons to throw, this LGTM
vtjnash
approved these changes
Nov 20, 2023
mkitti
pushed a commit
to mkitti/julia
that referenced
this pull request
Dec 9, 2023
…sn't have to be due to `__precompile__(false)` (JuliaLang#51367)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error pops up here and there but the root cause is never due to
__precompile__(false)