Revert 1.10 GC back to 1.8 GC heuristics #51661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-netto
force-pushed
the
dcn-1.8-heuristics
branch
2 times, most recently
from
74b967d
to
450bf5a
Compare
|
(Marking as "ready for review" to run a CI pass) |
d-netto
force-pushed
the
dcn-1.8-heuristics
branch
from
450bf5a
to
f18cd98
Compare
d-netto
force-pushed
the
dcn-1.8-heuristics
branch
from
f18cd98
to
e839b04
Compare
d-netto
force-pushed
the
dcn-1.8-heuristics
branch
from
e839b04
to
a6747ef
Compare
|
@nanosoldier |
|
The package evaluation job you requested has completed - possible new issues were detected. |
|
Will merge tomorrow if there are no objections. |
This was referenced Oct 20, 2023
oscardssmith
changed the title
d-netto
added a commit
that referenced
this pull request
Oct 24, 2023
Otherwise `--heap-size-hint` will become a no-op. Likely a merge bug from #51661.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1.10 GC heuristics introduced in #50144 have been a source of concerning issues such as #50705 and #51601. The PR also doesn't correctly implement the paper on which it's based, as discussed in #51498.
Test whether the 1.8 GC heuristics are a viable option.