Lower Pidfile stale_age multiplier. Add pidfile to cache log message. #51714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/pidlock_tweaks
branch
from
e18c39b
to
9c05c31
Compare
IanButterworth
added
the
backport 1.10
vchuravy
approved these changes
Oct 15, 2023
IanButterworth
force-pushed
the
ib/pidlock_tweaks
branch
from
faa30a0
to
a74ea69
Compare
vtjnash
reviewed
Oct 15, 2023
vtjnash
approved these changes
Oct 16, 2023
IanButterworth
added
the
status:merge me
IanButterworth
removed
the
status:merge me
KristofferC
removed
the
backport 1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This x25 pre-dated the current setup where the mtime of the lock file is refreshed every
stale_age/2seconds, so can be reduced.Regarding the cache pidlock, this means that different machines sharing a depot will now wait for 50 seconds rather than 4 minutes, given that they cannot do the faster 10 seconds stale assessment because they cannot check whether the process still exists.
Also include the pidfile path in the log message, so if the user wants to, they can
rmthe file and override the lock.Pkg counterpart JuliaLang/Pkg.jl#3654