Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make type hashing :total #52427

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Make type hashing :total #52427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9aebb4c
Allow type hashing to be concretely evaluated
Seelengrab Dec 6, 2023
0d4b026
Add effects test for type hashing
Seelengrab Dec 6, 2023
b3c731b
Fix effects testing per code review
Seelengrab Dec 7, 2023
5be5ed2
Update test/hashing.jl
Seelengrab Dec 7, 2023
77bfb46
Use callsite annotation instead of outlined function
Seelengrab Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion base/hashing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ See also: [`objectid`](@ref), [`Dict`](@ref), [`Set`](@ref).
"""
hash(x::Any) = hash(x, zero(UInt))
hash(w::WeakRef, h::UInt) = hash(w.value, h)
hash(T::Type, h::UInt) = hash_uint(3h - ccall(:jl_type_hash, UInt, (Any,), T))

# Types can't be deleted, so marking as total allows the compiler to look up the hash
hash(T::Type, h::UInt) = hash_uint(3h - @assume_effects :total ccall(:jl_type_hash, UInt, (Any,), T))

## hashing general objects ##

Expand Down
2 changes: 2 additions & 0 deletions test/hashing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,3 +302,5 @@ struct AUnionParam{T<:Union{Nothing,Float32,Float64}} end
# test hashing of rational with odd denominator
@test hash(5//3) == hash(big(5)//3)
end

@test Core.Compiler.is_foldable_nothrow(Base.infer_effects(hash, Tuple{Type{Int}, UInt}))