Ensure elision of require_one_based_indexing with high-dim array views
#53091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clean up has_offset_axes dispatch
|
This fixed one case but broke others. Tweaks are needed still |
|
The first fix was not the correct one. With the last commit we simplify the lispy recursion of CC: @N5N3 |
|
LGTM, I guess the doc string could be updated? ( |
N5N3
approved these changes
Jan 29, 2024
Done, thanks! |
pablosanjose
added
the
backport 1.10
barucden
reviewed
Jan 29, 2024
Co-authored-by: Denis Barucic <barucic.d@gmail.com>
KristofferC
removed
the
backport 1.10
KristofferC
added a commit
that referenced
this pull request
Feb 6, 2024
A few stragglers. Backported PRs: - [x] #53091 <!-- Ensure elision of `require_one_based_indexing` with high-dim array views --> - [x] #53117 <!-- Try to fix incorrect documentation of `nthreads` --> - [x] #52855 <!-- Fix variable name in scaling an `AbstractTriangular` with zero alpha --> - [x] #52952 <!-- [REPLCompletions] enable completions for `using Module.Inner|` --> - [x] #53101 <!-- Inplace transpose for unit Triangular may skip diagonal --> Need manual backport: - [ ] #52505 <!-- fix alignment of emit_unbox_store copy --> Non-merged PRs with backport label: - [ ] #53125 <!-- coverage: count coverage where explicitly requested by inference only --> - [ ] #52694 <!-- Reinstate similar for AbstractQ for backward compatibility --> - [ ] #51479 <!-- prevent code loading from lookin in the versioned environment when building Julia -->
Drvi
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jun 7, 2024
…ews (JuliaLang#53091) Closes JuliaLang#49332 --------- Co-authored-by: Denis Barucic <barucic.d@gmail.com> (cherry picked from commit 9edf1dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49332
Here I try to make the life of the compiler a bit easier by reorganising the dispatch structure of
has_offset_axes(#45260) into two layers. Avoiding the self-reference of thehas_offset_axes(As...)method seems to allow the elision of the call in my machine, which fixes #49332 by fully eliminatingrequire_one_based_indexingeven for the problematic case of views of 4+ dimensional arrays.