Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interpreter_exec.jl test #53218

Merged
merged 6 commits into from
Feb 10, 2024
Merged

Fix interpreter_exec.jl test #53218

merged 6 commits into from
Feb 10, 2024

Commits on Feb 9, 2024

  1. Fix interpreter_exec.jl test 

    This test was supposed to check that we correctly handled PhiNodes in uninferred
code in both the interpreter and the compiler. However, the compiler path wasn't
actually exercised, because the `inferred=true` part of this forced it to be skipped.
Drop that and fix the exposed issues in the compiler where we didn't handle PhiNodes
properly.
    @Keno @aviatesk
    Keno authored and aviatesk committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    f4ced3e View commit details
    Browse the repository at this point in the history

  2. handle unassigned PhiNode values in find_ssavalue_uses

    @aviatesk
    aviatesk committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    b8c24bb View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
    @vtjnash @aviatesk
    vtjnash and aviatesk committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    16703da View commit details
    Browse the repository at this point in the history

  4. Update base/compiler/abstractinterpretation.jl

    @vtjnash @aviatesk
    vtjnash authored and aviatesk committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    ab74bc2 View commit details
    Browse the repository at this point in the history

  5. refactors interpreter_exec.jl further (#53246) 

    This commit refines `interpreter_exec.jl` further, on top of #53218. In
detail, by using `Base.Experimental.@compiler_options compile=min`, it's
now possible to mimic the effect of `julia --compile=[min|yes]`. This
commit is leveraging it and includes `interpreter_exec.jl` from
`test/compiler/ssair.jl`, allowing us to get better stack traces and
test summaries.

In addition, I've introduced several tests concerning the `src.inferred`
values and have relocated the tests from #47066 within
`interpreter_exec.jl` to `test/compiler/irpasses.jl`, since it is
related to Julia-level compilation and not to interpreter execution.
    @aviatesk
    aviatesk committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    d056498 View commit details
    Browse the repository at this point in the history

  6. better argument order

    @aviatesk
    aviatesk committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    750948b View commit details
    Browse the repository at this point in the history