Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move isassigned within inbounds in copyto_unaliased #53311

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Feb 13, 2024

This matches the other branches where the isassigned and _unsetindex! are within @inbounds blocks, and this might help with performance after #53305

@jishnub jishnub added performance Must go faster domain:arrays [a, r, r, a, y, s] labels Feb 13, 2024
@vtjnash vtjnash added the status:merge me PR is reviewed. Merge when all tests are passing label Feb 13, 2024
@jishnub jishnub merged commit 52006ae into master Feb 14, 2024
10 of 12 checks passed
@jishnub jishnub deleted the jishnub/copytoinboundscartinds branch February 14, 2024 12:13
@giordano giordano removed the status:merge me PR is reviewed. Merge when all tests are passing label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:arrays [a, r, r, a, y, s] performance Must go faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants