Throw OverflowError on copysign(typemin(Int)//1, 1)
#53395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
the
status:merge me
vtjnash
added a commit
that referenced
this pull request
Feb 21, 2024
Follow up to #53373, it seems this assert was broken for empty packages, causing CI issues. It is not necessary. Observed in CI here: #53395 https://buildkite.com/julialang/julia-master/builds/33860#018dc4dc-a603-4ad1-90cf-574540a41720
inkydragon
removed
the
status:merge me
KristofferC
pushed a commit
that referenced
this pull request
Feb 26, 2024
Follow up to #53373, it seems this assert was broken for empty packages, causing CI issues. It is not necessary. Observed in CI here: #53395 https://buildkite.com/julialang/julia-master/builds/33860#018dc4dc-a603-4ad1-90cf-574540a41720 (cherry picked from commit 3742d33)
tecosaur
pushed a commit
to tecosaur/julia
that referenced
this pull request
Mar 4, 2024
Follow up to JuliaLang#53373, it seems this assert was broken for empty packages, causing CI issues. It is not necessary. Observed in CI here: JuliaLang#53395 https://buildkite.com/julialang/julia-master/builds/33860#018dc4dc-a603-4ad1-90cf-574540a41720
tecosaur
pushed a commit
to tecosaur/julia
that referenced
this pull request
Mar 4, 2024
The default `copysign(x::Real, y::Real)` in `number.jl` works, so the
incorrect method in `rational.jl` isn't needed.
Here is a benchmark of the new version.
```julia
using BenchmarkTools
function foo!(c,a,b)
c .= copysign.(a, b)
nothing
end
N = 1000
@Btime foo!(c,a,b) setup=(c=zeros(Rational{Int},N); a=rand(Int,N).//rand(Int,N); b=fill(-1,N))
```
On master: 406.215 ns (0 allocations: 0 bytes)
On this PR: 869.327 ns (0 allocations: 0 bytes)
mkitti
pushed a commit
to mkitti/julia
that referenced
this pull request
Mar 7, 2024
Follow up to JuliaLang#53373, it seems this assert was broken for empty packages, causing CI issues. It is not necessary. Observed in CI here: JuliaLang#53395 https://buildkite.com/julialang/julia-master/builds/33860#018dc4dc-a603-4ad1-90cf-574540a41720
mkitti
pushed a commit
to mkitti/julia
that referenced
this pull request
Mar 7, 2024
The default `copysign(x::Real, y::Real)` in `number.jl` works, so the
incorrect method in `rational.jl` isn't needed.
Here is a benchmark of the new version.
```julia
using BenchmarkTools
function foo!(c,a,b)
c .= copysign.(a, b)
nothing
end
N = 1000
@Btime foo!(c,a,b) setup=(c=zeros(Rational{Int},N); a=rand(Int,N).//rand(Int,N); b=fill(-1,N))
```
On master: 406.215 ns (0 allocations: 0 bytes)
On this PR: 869.327 ns (0 allocations: 0 bytes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
copysign(x::Real, y::Real)innumber.jlworks, so the incorrect method inrational.jlisn't needed.Here is a benchmark of the new version.
On master: 406.215 ns (0 allocations: 0 bytes)
On this PR: 869.327 ns (0 allocations: 0 bytes)