Explicitly call out reverse ranges in : and range docstring
#53626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BioTurboNick
changed the title
: docstring: and range docstring
stevengj
reviewed
Mar 6, 2024
stevengj
reviewed
Mar 6, 2024
Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
stevengj
reviewed
Mar 7, 2024
jishnub
reviewed
Mar 7, 2024
stevengj
reviewed
Mar 7, 2024
Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
stevengj
approved these changes
Mar 13, 2024
stevengj
added
the
status:merge me
fatteneder
removed
the
status:merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People often think
5:1should make a range from 5 to 1.Might be worth emphasizing this issue and how to really do it in the docstring for
:, as suggested in this PR.See e.g.: https://discourse.julialang.org/t/question-about-range-operator/111247/5